feat: add Client::insertPayload() and slightly refactor sql logging
#279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
simPod
commented
Jan 15, 2025
•
simPod
commented
- remove LoggerPlugin
- move sql logging directly into Client
- add logging into PsrClickHouseAsyncClient
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #279 +/- ##
==========================================
+ Coverage 93.39% 94.60% +1.21%
==========================================
Files 38 39 +1
Lines 696 723 +27
==========================================
+ Hits 650 684 +34
+ Misses 46 39 -7 ☔ View full report in Codecov by Sentry. |
simPod
force-pushed
the
insert
branch
10 times, most recently
from
6628251 to
253b7dc
Compare
simPod
changed the title
Client::insertPayload()Client::insertPayload() and slightly refactor sql logging
- remove LoggerPlugin - move sql logging directly into Client - add logging into PsrClickHouseAsyncClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.